Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update cfnspec from source #1959

Merged
merged 2 commits into from
Mar 6, 2019
Merged

chore: update cfnspec from source #1959

merged 2 commits into from
Mar 6, 2019

Conversation

sam-goodwin
Copy link
Contributor

@sam-goodwin sam-goodwin commented Mar 5, 2019 •
edited
Loading

Updates CFN spec from source.

Source spec now fixes the VpcEndpointType case error: #765

Fixes #1388

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin requested a review from a team as a code owner March 5, 2019 22:00
@sam-goodwin
Copy link
Contributor Author

Should this be chore or fix(cfnpec)?

@RomainMuller
Copy link
Contributor

@sam-goodwin - chore: is appropriate, I think. Could also be feat I reckon, had there are actually been new features in there.

RomainMuller
RomainMuller approved these changes Mar 6, 2019
View reviewed changes
packages/@aws-cdk/cfnspec/spec-source/000_CloudFormationResourceSpecification.json
@@ -33429,7 +33508,7 @@
"Protocol": {
"Documentation": "http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-sns-subscription.html#cfn-sns-protocol",
"PrimitiveType": "String",
"Required": false,
"Required": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh - that's a dodgy change... Making optional properties required... Wow CFN, not thank you!

@RomainMuller RomainMuller merged commit f5a7baa into master Mar 6, 2019
@RomainMuller RomainMuller deleted the samgood/update-cfnspec branch March 6, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CloudWatch alarm is missing metrics: MetricDataQuery[] field
2 participants
@sam-goodwin @RomainMuller